Dan Kenigsberg has posted comments on this change.
Change subject: Fix vdsm-faqemu VM launch failure on hosts with newer libvirt
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm_hooks/faqemu/vdsm-faqemu
Line 20:
Line 21: qemu_argv += filter(lambda x: x != "-enable-kvm", sys.argv[1:])
Line 22: # libvirt 0.9.10+ checks for the presence of /dev/kvm to provide
Line 23: # better error messages, but this breaks this hook, fake it out
Line 24: os.system("touch /dev/kvm")
how can this work? this script runs as vdsm.
also, there are less expensive ways to create a file - how about shipping it in
this hook's rpm ?
--
To view, visit http://gerrit.ovirt.org/7223
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1dc88f2931e8f716c1732a51d9f65f600f4fd1ef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
