Francesco Romani has posted comments on this change. Change subject: virt: migration: create full status in migration.py ......................................................................
Patch Set 2: Code-Review-1 (1 comment) -1 for visibility v2 seems just a rebase, please check my comments in v1. I'm still not convinced this patch is actually beneficial to your case besides cleanup (which IS welcome, btw). https://gerrit.ovirt.org/#/c/43357/2/vdsm/API.py File vdsm/API.py: Line 353 Line 354 Line 355 Line 356 Line 357 so IIUC the key point behind this patch is NOT to hardcode the doneCode (aka success) status -- To view, visit https://gerrit.ovirt.org/43357 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbc1525f52dc5ee49647aa6d690f221f2dc96e5d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
