Dan Kenigsberg has posted comments on this change. Change subject: net: test_setupNetworks_bond_with_custom_option with ifcfg persistence ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/43467/1/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 2474: self.assertEquals(opts, 'mode=balance-rr') Line 2475: else: # ifcfg persistence Line 2476: with open(NET_CONF_PREF + BONDING_NAME) as f: Line 2477: for l in f: Line 2478: if l.startswith('BONDING_OPTS='): why don't you use a simple equality? BONDING_OPTS=mode=balance-rr do you expect having something else there? Line 2479: self.assertIn('mode=balance-rr', l) Line 2480: self.assertNotIn('custom=foo', l) Line 2481: Line 2482: status, msg = self.setupNetworks( -- To view, visit https://gerrit.ovirt.org/43467 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I178383e2c0125a1a661108ca9bbb28da74b1a11a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
