Francesco Romani has posted comments on this change. Change subject: hostdev: add basic unit tests for XML ......................................................................
Patch Set 4: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/43088/4/tests/hostdevTests.py File tests/hostdevTests.py: Line 363: 'vmId': '9ffe28b6-6134-4b1e-8804-1185f49c436f', Line 364: 'smp': '8', 'maxVCpus': '160', Line 365: 'memSize': '1024', 'memGuaranteedSize': '512'} Line 366: Line 367: @permutations([[device] for device in _PCI_DEVICES + _USB_DEVICES]) even better than before :) Line 368: def testCreateHostDevice(self, device_name): Line 369: dev_spec = {'type': 'hostdev', 'device': device_name} Line 370: device = hostdevice.HostDevice(self.conf, self.log, **dev_spec) -- To view, visit https://gerrit.ovirt.org/43088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I723a8876382f778441b015c7c0f453d0888d7f6b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
