Nir Soffer has posted comments on this change. Change subject: sp: Move spm validation methods to StoragePool ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/43542/1/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 548: if domVersion is not None: Line 549: domVersion = int(domVersion) Line 550: sd.validateDomainVersion(domVersion) Line 551: Line 552: # This code is repeated twice for performance reasons > this 4yo comment is not very clear. Could you rephrase it to ok Line 553: # Avoid waiting for the lock for validate. Line 554: self.getPool(spUUID).validateNotSPM() Line 555: Line 556: vars.task.getExclusiveLock(STORAGE, spUUID) -- To view, visit https://gerrit.ovirt.org/43542 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I115896cc67634741d7227fc00d8b294b3fe48ac6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
