Nir Soffer has posted comments on this change. Change subject: spbackends: Move backend functions to spbackends ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/43463/1/vdsm/storage/spbackends.py File vdsm/storage/spbackends.py: Line 53: MAX_DOMAINS -= blockSD.PVS_METADATA_SIZE Line 54: MAX_DOMAINS /= 48 Line 55: Line 56: Line 57: def domainListEncoder(domDict): > any reason not to name them _private ? No, will make them private. Line 58: domains = ','.join(['%s:%s' % (k, v) for k, v in domDict.iteritems()]) Line 59: return domains Line 60: Line 61: -- To view, visit https://gerrit.ovirt.org/43463 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibde69dda90de62dea222a5ca5badca913749e75e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
