Arik Hadas has posted comments on this change. Change subject: v2v: enable to use external virtio drivers for virtio ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/42996/2/vdsm/v2v.py File vdsm/v2v.py: Line 375: Line 376: def _execution_environments(self): Line 377: env = {'LIBGUESTFS_BACKEND': 'direct'} Line 378: if 'virtio_iso_path' in self._vminfo: Line 379: env['VIRTIO_WIN'] = self._vminfo['virtio_iso_path'] > its drivers that we are available via Fedora here: Francesco, the given path is to an iso that resides in an iso-domain, which should contain only trusted iso files. It is up to the user to select an iso that actually contains virtio-drivers, if it's not - v2v will fail. Line 380: return env Line 381: Line 382: def _wait_for_process(self): Line 383: if self._proc.returncode is not None: -- To view, visit https://gerrit.ovirt.org/42996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74326b880960c21185cd4ce007852bf0c703d192 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches