Arik Hadas has posted comments on this change. Change subject: v2v: handle exception on probing external VMs ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/43259/1//COMMIT_MSG Commit Message: Line 7: v2v: handle exception on probing external VMs Line 8: Line 9: XMLDesc of libvirt domain can throw error, Line 10: We don't want to fail all the process of fetching external VMs if we Line 11: fail to read one VM xml. > You may be right here, The only thing that was special for that VM was that it contained vcenter that was't completely installed. But as Shahar wrote, newer vsphere was already installed and we don't know exactly how to reproduce it on the new setup. It might be a problem in libvirt on the client side or on the server side (the implementation of the libvirt driver in VMware's ESX). I think we should be extra-careful on this since we communicate with external systems that we can't really trust. Line 12: Line 13: Change-Id: Ie3203dde4878a80c65fe3185cadaef2fe00e6a02 -- To view, visit https://gerrit.ovirt.org/43259 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3203dde4878a80c65fe3185cadaef2fe00e6a02 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
