Ido Barkan has posted comments on this change.

Change subject: net: also support replacing VLAN device under a bridge
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/43710/4/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 1005: 
Line 1006:         def add_tap_to_bridge():
Line 1007:             tap = Tap()
Line 1008:             tap.addDevice()
Line 1009:             execCmd([EXT_BRCTL, 'addif', NETWORK_NAME, tap.devName])
> raise if rc!=0
Done
Line 1010:             return tap.devName
Line 1011: 
Line 1012:         def remove_tap_from_bridge(tap_name):
Line 1013:             execCmd([EXT_BRCTL, 'delif', NETWORK_NAME, tap_name])


-- 
To view, visit https://gerrit.ovirt.org/43710
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I806410e5d2ee2a4794e3547f52ef43804d010d1c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ido Barkan <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to