Dan Kenigsberg has posted comments on this change. Change subject: netinfo: improve which ipv4 addr is reported. ......................................................................
Patch Set 5: Code-Review-1 (3 comments) nits https://gerrit.ovirt.org/#/c/33375/5/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 33: import struct Line 34: import xml.etree.cElementTree as etree Line 35: Line 36: from . import constants Line 37: from netaddr import IPNetwork please place in former import block Line 38: from .ipwrapper import drv_name Line 39: from .ipwrapper import DUMMY_BRIDGE Line 40: from .ipwrapper import getLink, getLinks, Link Line 41: from .ipwrapper import IPRoute2Error https://gerrit.ovirt.org/#/c/33375/5/tests/netinfoTests.py File tests/netinfoTests.py: Line 353: 192.168.1.9 How about using the test range? I recall that there's another patch brewing about this. Line 375: 192.168.1.1 begs to be included as a named CONSTANT -- To view, visit https://gerrit.ovirt.org/33375 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8666cfef5bd8ea63edf8979e501d4785db5f4893 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <toni+ov...@midokura.com> Gerrit-Reviewer: Antoni Segura Puimedon <toni+ov...@midokura.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
