Dan Kenigsberg has posted comments on this change. Change subject: net: configurators: persist custom bond option ......................................................................
Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/43891/6/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 2647: 'options': 'custom=foo mode=4'}}, Line 2648: NOCHK, test_kernel_config=False) Line 2649: self.assertEqual(status, SUCCESS, msg) Line 2650: self.assertBondExists(BONDING_NAME, nics) Line 2651: # custom property must not be shown in netinfo and has to be actually, I think that reporting custom property in netinfo (if it is found to be persisted) makes a lot of sense. Without it, Engine would mark the bond as "out of sync", or would have to be aware of the specialness of the "custom" option. It should be quite easy for Vdsm to report "custom" as well. Line 2652: # persisted (if unified persistence is used). Line 2653: self._assert_exact_bond_opts(BONDING_NAME, ['mode=4']) Line 2654: if vdsm.config.config.get('vars', 'net_persistence') == 'unified': Line 2655: bond = self.vdsm_net.config.bonds.get(BONDING_NAME) -- To view, visit https://gerrit.ovirt.org/43891 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4f1564e19904cc1d53bc6d1cf732ca35375332e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
