Dan Kenigsberg has posted comments on this change.

Change subject: hooks: Open vSwitch configurator
......................................................................


Patch Set 51:

(3 comments)

https://gerrit.ovirt.org/#/c/40312/51/tests/functional/utils.py
File tests/functional/utils.py:

Line 173: OVS requires at least a nic/bonding
why is that? is there any problem disconnecting a ovs bridge from all nics?


https://gerrit.ovirt.org/#/c/40312/51/vdsm_hooks/ovs/ovs_after_get_stats.py
File vdsm_hooks/ovs/ovs_after_get_stats.py:

Line 42: VDSM
       :                 # is (?) expecting
Engine expects


Line 48: VDSM
actually, it is Engine that expect these


-- 
To view, visit https://gerrit.ovirt.org/40312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f
Gerrit-PatchSet: 51
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ido Barkan <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to