Dan Kenigsberg has posted comments on this change. Change subject: virt: Only filter guest agent data, only on XMLRPC ......................................................................
Patch Set 17: (2 comments) https://gerrit.ovirt.org/#/c/36949/17//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-01-07 11:32:48 +0100 Line 4: Commit: Vinzenz Feenstra <[email protected]> Line 5: CommitDate: 2015-07-13 09:19:26 +0200 Line 6: Line 7: virt: Only filter guest agent data, only on XMLRPC would you add a word about the motivation for this? (reducing CPU consumption, I suppose) Have you tested that jsonrpc is capable of marshalling all funny characters? Line 8: Line 9: As a side effect of this change, the data has to be all unicode Line 10: in order to have the filtering applied properly. Line 11: Line 6: Line 7: virt: Only filter guest agent data, only on XMLRPC Line 8: Line 9: As a side effect of this change, the data has to be all unicode Line 10: in order to have the filtering applied properly. sorry, I don't understand why was that required, or why all string literals had to be converted to unicode. Would you explain? Line 11: Line 12: Change-Id: Ia9ee2a8f1cc6784c619ce68da3cb9342b0d72cfc Line 13: Bug-Url: https://bugzilla.redhat.com/1179696 -- To view, visit https://gerrit.ovirt.org/36949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ee2a8f1cc6784c619ce68da3cb9342b0d72cfc Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
