Ido Barkan has posted comments on this change. Change subject: concurrent: Add Barrier class ......................................................................
Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/42927/11/lib/vdsm/concurrent.py File lib/vdsm/concurrent.py: Line 73: if count < 1: Line 74: raise ValueError("Invalid count %d (expecting count >= 1)" % count) Line 75: self._count = count Line 76: self._waiting = 0 Line 77: self._closed = True > I disagree - the only place we check this flag is in _wait() and _wait_unti true but we also set it a few times and setting it is more readable: self._open = True Line 78: self._cond = threading.Condition(threading.Lock()) Line 79: Line 80: def wait(self, timeout=None): Line 81: """ -- To view, visit https://gerrit.ovirt.org/42927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68525e18f6b3774d7e10af1226a7bc3404c68ae9 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
