Dan Kenigsberg has posted comments on this change. Change subject: Optimize _getConfigValue to return multiple values ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/configNetwork.py Line 486: subprocess.call([constants.EXT_BRCTL, 'delbr', bridge]) Line 487: self._backup(self.NET_CONF_PREF + bridge) Line 488: self._removeFile(self.NET_CONF_PREF + bridge) Line 489: Line 490: def _getConfigValue(self, conffile, entries): now this function has become way to similar to netinfo.getIfaceCfg() please consider using it all over the place. Line 491: """ Line 492: Get values from network configuration file Line 493: Line 494: :param entry: entries to look for (entry=value) -- To view, visit http://gerrit.ovirt.org/7306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15ff5542095d51f33f5f1970b81a4a0cbfb30632 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
