Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix a race existing in the singleton interface of clientIF ......................................................................
Fix a race existing in the singleton interface of clientIF There's a race in getInstance() between clientIF initialization and MOM thread. If for some reason the initialization of clientIF is slowed down and not finished before MOM calls vdsm API, an exception will happen in MOM thread due to that the parameter 'log' is missing. The fix is just moving the parameter check into the protection of the singleton lock. Then MOM thread will be blocked if it tries to access vdsm API when the initialization of clientIF is ongoing. Change-Id: I6d907f5613963438c99749da674bb6588a23fe38 Signed-off-by: Mark Wu <[email protected]> --- M vdsm/clientIF.py 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Adam Litke: Verified; Looks good to me, but someone else must approve Royce Lv: Looks good to me, but someone else must approve Mark Wu: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d907f5613963438c99749da674bb6588a23fe38 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
