Dan Kenigsberg has posted comments on this change.

Change subject: BZ829710 Get VMList with oop if necessary
......................................................................


Patch Set 3: Fails

(1 inline comment)

the robot has checked out the wrong branch.

 vdsm/storage/sd.py:25: 'glob' imported but unused

....................................................
File vdsm/storage/sd.py
Line 20: 
Line 21: import os
Line 22: import logging
Line 23: import types
Line 24: import threading
this has to be removed, or pylakes would cry.
Line 25: from glob import glob
Line 26: from collections import namedtuple
Line 27: import codecs
Line 28: 


--
To view, visit http://gerrit.ovirt.org/6867
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I021e9d03b29dfc9cf1c3b7fa5ec8a302e7912cf7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dafna Ron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to