Dan Kenigsberg has posted comments on this change. Change subject: vm: make up pauseCode if libvirt is omitting it ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/44115/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3591: :param err: one of "eperm", "eio", "enospc" or "eother" Line 3592: Note the different API from that of Vm._onAbnormalStop Line 3593: """ Line 3594: # libvirt <= 1.2.18 sends either reason="enospc" or reason="". Line 3595: # Engine doesn't like disappearing pauseCode, so we fill the gap what does newer libvirt do? please be more specific so we can drop this comment in the future. Line 3596: reason = err.upper() if err else "EOTHER" Line 3597: Line 3598: if action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_PAUSE: Line 3599: self.log.info('abnormal vm stop device %s error %s', -- To view, visit https://gerrit.ovirt.org/44115 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bde0561cae20971effcf01c8a57159edcc4c42e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
