Arik Hadas has posted comments on this change.

Change subject: v2v: Import VM from OVA file
......................................................................


Patch Set 2: Verified-1

(1 comment)

https://gerrit.ovirt.org/#/c/43367/2/vdsm/v2v.py
File vdsm/v2v.py:

Line 349:     def from_ova(cls, ova_path, vminfo, job_id, irs):
Line 350:         obj = cls(vminfo, job_id, irs)
Line 351: 
Line 352:         obj._ova_path = ova_path
Line 353:         obj._create_command = obj._from_ova_command
need to specify somehow that the password file is not needed in this flow
Line 354:         return obj
Line 355: 
Line 356:     def start(self):
Line 357:         t = threading.Thread(target=self._run)


-- 
To view, visit https://gerrit.ovirt.org/43367
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e440748ecc503f4d61e8f4f61bb0c7387589354
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to