Francesco Romani has posted comments on this change. Change subject: jsonrpc: ignore unknown message id ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/43746/1/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 295: def requestDone(self, response): Line 296: try: Line 297: del self._requests[response.id] Line 298: except KeyError: Line 299: # ignore when request had no id the comment and the code disagree here, because here you are ignoring responses with id not present in the _requests dict. Better to either fix the comment describing when this happens Line 300: pass Line 301: self.addResponse(response) Line 302: self.sendReply() Line 303: -- To view, visit https://gerrit.ovirt.org/43746 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide306f44c8c42d6661932698307efa4ce163e90e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
