Dan Kenigsberg has posted comments on this change. Change subject: register: use node name and fqdn when needed ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/44221/1/lib/vdsm/tool/register.py File lib/vdsm/tool/register.py: Line 147: Line 148: if self.node_name is not None: Line 149: ureg += "&name={name}".format(name=self.node_name) Line 150: Line 151: if self.node_fqdn is not None: I think that for the end user, it is quite useful to see a human-readable name. If this script does not supply a name by default - who does? Line 152: ureg += "&address={fqdn}".format(fqdn=self.node_fqdn) Line 153: Line 154: self.url_reg = "{e}{u}".format(e=self.engine_url, u=ureg) Line 155: -- To view, visit https://gerrit.ovirt.org/44221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91c834e10cade4878791be43201ab0966bf251b4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
