Arik Hadas has posted comments on this change. Change subject: v2v: get VM information from OVA file ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/43271/4/vdsm/v2v.py File vdsm/v2v.py: Line 175: root = ET.fromstring(_read_ovf_from_ova(ova_path)) Line 176: except ET.ParseError as e: Line 177: raise V2VError('Error reading ovf from ova, position: %r' % e.position) Line 178: Line 179: vm = {} > Should this contain exactly one VM? right, we do it like that so we could reuse the response type of full-list instead of presenting yet another struct in the engine Line 180: _add_general_ovf_info(vm, root, ns) Line 181: _add_disks_ovf_info(vm, root, ns) Line 182: _add_networks_ovf_info(vm, root, ns) Line 183: -- To view, visit https://gerrit.ovirt.org/43271 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c55c846f837bb5bf363717e05daabf5ee6631ca Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
