Francesco Romani has posted comments on this change. Change subject: virt: remove duplicate connection in hostdevTests ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/40946/2/tests/vmfakelib.py File tests/vmfakelib.py: Line 87: Line 88: def listAllDevices(self, flags=0): Line 89: pass Line 90: Line 91: @staticmethod related? Line 92: def nodeDeviceLookupByName(name): Line 93: """ Line 94: This is a method that allows us to access hostdev XML in a test. Line 95: Normally, libvirt holds the device XML but in case of unit testing, Line 170: def listAllDevices(_, flags=0): Line 171: return vir_node_devices Line 172: Line 173: with MonkeyPatchScope( Line 174: [(libvirtconnection.get, 'listAllDevices', listAllDevices)] not sure this works as intended. I'm suspicious of the first argoment. Shouldn't wrap a Connection (fake or real) object? Line 175: ): Line 176: return func(*args, **kwargs) Line 177: return wrapper Line 178: return decorator -- To view, visit https://gerrit.ovirt.org/40946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I936766c8fd4c87175dcc3987d7ae5c64ff5675ea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
