Francesco Romani has posted comments on this change. Change subject: Modifying _cleanOldFiles to current _cleanRecoveryFile and avoid naked tryblock ......................................................................
Patch Set 2: Code-Review+1 (1 comment) Nice improvement. Besides that, I have mid-term plans to move vm-recovery code under virt/ , and this goes in the same direction. https://gerrit.ovirt.org/#/c/43207/2/vdsm/clientIF.py File vdsm/clientIF.py: Line 547: try: Line 548: vmId, fileType = f.split(".", 1) Line 549: except ValueError: Line 550: # If file is missing type extention - ignore it Line 551: pass maybe continue is clearer? I don't really know Line 552: else: Line 553: if fileType == "recovery" and vmId not in self.vmContainer: Line 554: self.log.debug("cleaning old file " + f) Line 555: utils.rmFile(constants.P_VDSM_RUN + f) -- To view, visit https://gerrit.ovirt.org/43207 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie5c1053e268abb03c71935a4414a193a1ed40e9f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
