Dan Kenigsberg has posted comments on this change. Change subject: register: Add --persist-uuid ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/44431/1/lib/vdsm/tool/register.py File lib/vdsm/tool/register.py: Line 275: f.write(self.uuid) Line 276: Line 277: if utils.isOvirtNode(): Line 278: from ovirt.node.utils.fs import Config Line 279: Config().persist(__VDSM_ID) we persist the uuid anyway, so the name of the new argument is misleading. --persist-uuid should mean "I would like to write VDSM_ID onto the filesystem". in this patch you are adding something like --vdsm-uuid - override the default vdsm uuid. this may be useful if dmidecode returns an unconfigured host id. Line 280: Line 281: self.logger.info("Host UUID: {u}".format(u=self.uuid)) Line 282: Line 283: def download_ca(self): -- To view, visit https://gerrit.ovirt.org/44431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5926b635201662db53956dbac18b9a2981d6e645 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
