Dan Kenigsberg has posted comments on this change. Change subject: network: add ifcfg write hook ......................................................................
Patch Set 1: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/44552/1//COMMIT_MSG Commit Message: Line 11: executing setupNetworks. Line 12: The hook script receives a json file containing the Line 13: following dict: Line 14: name: the name of the interface being configured Line 15: ifcfg_file: full path of the interface file being written please docuemnt the new hook points in vdsm/vdsmd.8.in. Line 16: config: the contents of the config file being written Line 17: Line 18: Change-Id: I2206ccf97b210bd58f03777d4ccd016785b02939 https://gerrit.ovirt.org/#/c/44552/1/vdsm/hooks.py File vdsm/hooks.py: Line 390: return _runHooksDir(caps, 'after_get_stats', raiseError=False, Line 391: hookType=_JSON_HOOK) Line 392: Line 393: Line 394: def before_ifcfg_write(hook_dict): please mention in the commit message that this hook point is useful for people who would like to tweak the vdsm-produced ifcfg files, e.g. by adding a PEERDNS=no line to it. Line 395: return _runHooksDir(hook_dict, 'before_ifcfg_write', raiseError=False, Line 396: hookType=_JSON_HOOK) Line 397: Line 398: Line 395: return _runHooksDir(hook_dict, 'before_ifcfg_write', raiseError=False, Line 396: hookType=_JSON_HOOK) Line 397: Line 398: Line 399: def after_ifcfg_write(hook_dict): can you think of a use case for this hook? Line 400: return _runHooksDir(hook_dict, 'after_ifcfg_write', raiseError=False, Line 401: hookType=_JSON_HOOK) Line 402: Line 403: -- To view, visit https://gerrit.ovirt.org/44552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2206ccf97b210bd58f03777d4ccd016785b02939 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
