Meni Yakove has posted comments on this change. Change subject: configNetwork: use MTU as int in setNewMtu ......................................................................
Patch Set 2: Fails (1 inline comment) Can't attach 2 network with MTU to interface. MainProcess|Thread-517::ERROR::2012-08-21 09:21:07,647::configNetwork::1289::setupNetworks::(setupNetworks) %d format: a number is required, not str .................................................... File vdsm/configNetwork.py Line 567: """ Line 568: for nic in nics: Line 569: cf = self.NET_CONF_PREF + nic Line 570: mtuval = self._getConfigValue(cf, 'MTU') Line 571: if not mtuval is None: mtuval = int(mtuval) if mtuval > mtu: Line 572: if int(mtuval) > mtu: Line 573: mtu = mtuval Line 574: return mtu Line 575: -- To view, visit http://gerrit.ovirt.org/7360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ab6c3c624c284a8ffed34f16836a1d3d75f8eea Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Meni Yakove <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
