Francesco Romani has posted comments on this change. Change subject: vm: do not log known missing alias ......................................................................
Patch Set 1: Code-Review-1 (1 comment) I shouldn't be sloppy fixing this. https://gerrit.ovirt.org/#/c/44669/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4478: for devType in self._devices: Line 4479: for dev in self._devices[devType]: Line 4480: if hasattr(dev, 'alias'): Line 4481: aliasToDevice[dev.alias] = dev Line 4482: elif defType in (hwclass.GRAPHICS, ): > Well for now this might be fine, but I rather would see this tuple to be a good points. Will move to a plain comparison and use a constant. Line 4483: # we expect these failures, we don't log to not Line 4484: # confuse the user Line 4485: pass Line 4486: else: -- To view, visit https://gerrit.ovirt.org/44669 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63bc6d8f4b6fed52ee0af12f129007a1044d413b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches