Nir Soffer has posted comments on this change. Change subject: hostdev: add udev rules for USB devices ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/44679/3/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 296: raise OSError(errno.EINVAL, "Could not trigger change for device \ Line 297: %s, out %s\nerr %s" % (guid, out, err)) Line 298: Line 299: @logDecorator Line 300: def udevTriggerUSB(self, bus, device): > I agree. The tricky part is that we either refactor it first and then creat I don't see a need to backport half-baked api, and I don't want to support this in the field. We have the time to do this properly. I think the best way would be: - Remove unneeded stuff in supervdsm - Move the implementation of udevTrigger() here to trigger() - Refactor trigger() so it can serve both direct luns (guid) and usb devices - Add the code using this new infrastructure Line 301: self.__udevReloadRules('usb_' + '_'.join((bus, device))) Line 302: cmd = [EXT_UDEVADM, 'trigger', '--verbose', '--action', 'change', Line 303: '--attr-match=busnum={}'.format(bus), Line 304: '--attr-match=devnum={}'.format(device)] -- To view, visit https://gerrit.ovirt.org/44679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f72f63186187254cd4aded0a2e6c396001ca28b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
