Hello Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/44749
to review the following change.
Change subject: v2v: import abort/done status fix
......................................................................
v2v: import abort/done status fix
when importing is done need to check if the user aborted, if so no
need to change the job status to done.
Change-Id: I6fc3febe19a9602df63fa414edf7446a02416c66
Signed-off-by: Shahar Havivi <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/44470
Continuous-Integration: Jenkins CI
Tested-by: Shahar Havivi <[email protected]>
Reviewed-by: Francesco Romani <[email protected]>
---
M vdsm/v2v.py
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/44749/1
diff --git a/vdsm/v2v.py b/vdsm/v2v.py
index 04c7c89..4c474fc 100644
--- a/vdsm/v2v.py
+++ b/vdsm/v2v.py
@@ -383,8 +383,9 @@
(self._id, self._proc.returncode,
self._proc.stderr.read(1024)))
- logging.info('Job %r finished import successfully', self._id)
- self._status = STATUS.DONE
+ if self._status != STATUS.ABORTED:
+ self._status = STATUS.DONE
+ logging.info('Job %r finished import successfully', self._id)
def _execution_environments(self):
env = {'LIBGUESTFS_BACKEND': 'direct'}
--
To view, visit https://gerrit.ovirt.org/44749
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6fc3febe19a9602df63fa414edf7446a02416c66
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
