Hello Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/44748
to review the following change.
Change subject: v2v: Abort job need not to clean the job
......................................................................
v2v: Abort job need not to clean the job
When aborting a v2v job there is no need to delete it from the job
collection. (The job deletion will be handled by the engine)
Change-Id: Iba9b4c1abba829c269339dfcae8eec38a301e1f2
Signed-off-by: Shahar Havivi <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/44345
Reviewed-by: Francesco Romani <[email protected]>
Continuous-Integration: Jenkins CI
Tested-by: Shahar Havivi <[email protected]>
---
M vdsm/v2v.py
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/44748/1
diff --git a/vdsm/v2v.py b/vdsm/v2v.py
index d252826..04c7c89 100644
--- a/vdsm/v2v.py
+++ b/vdsm/v2v.py
@@ -193,7 +193,6 @@
try:
job = _get_job(job_id)
job.abort()
- _remove_job(job_id)
except ClientError as e:
logging.info('Cannot abort job, error: %s', e)
return errCode[e.err_name]
--
To view, visit https://gerrit.ovirt.org/44748
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba9b4c1abba829c269339dfcae8eec38a301e1f2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
