Dima Kuznetsov has posted comments on this change. Change subject: supervdsm: Decorator for supervdsm proxied calls. ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/44598/4/tests/functional/supervdsmFuncTests.py File tests/functional/supervdsmFuncTests.py: Line 40: os.setuid(vdsm_uid) Line 41: dropPrivileges() Line 42: Line 43: Line 44: class TestSuperVdsmRemotely(TestCaseBase): > Please add a test which throws exception on the server side. The test test_proxied_call_fails_on_unknown_function kind of does that, but at the moment, the only proxied call I have is hwinfo.get_hardware_info, which I see no easy way to force it to raise an exception and I'd rather not add a testing only function into vdsm lib. The behavior is exactly the same as with getProxy().anyOtherCall() Line 45: def testPingCall(self): Line 46: proxy = supervdsm.getProxy() Line 47: self.assertTrue(proxy.ping()) Line 48: -- To view, visit https://gerrit.ovirt.org/44598 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibea2b07b91a7faffda16c71c6b5831f96d116c15 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
