Mark Wu has posted comments on this change. Change subject: test: Add tests for _validateInterNetworkCompatibility() ......................................................................
Patch Set 1: (2 inline comments) .................................................... File tests/configNetworkTests.py Line 283: configNetwork.ne.ERR_USED_NIC) Line 284: Line 285: # Test for adding a new VLANed bridged network Line 286: # when a non-VLANed bridged network exists Line 287: self._addNetworkWithExc((netinfoIns, 'test', '2', 'bond00', nics, Sorry, I can't follow your question. The existing bond device 'bond00' is used by a non-VLANed bridged network 'fakebrnet1', so I choose 'bond00' to add a new VLANed bridged or bridgeless network. It should cause conflict. I think 'bond00' is fine for the test. Line 288: ipaddr, netmask, gw, bondingOptions), Line 289: configNetwork.ne.ERR_BAD_PARAMS) Line 290: Line 291: # Test for adding a new VLANed bridgeless network Line 295: False), Line 296: configNetwork.ne.ERR_BAD_PARAMS) Line 297: Line 298: # Test for adding a new VLANed bridged network Line 299: # when the interface is in used for any type of networks thanks for the fix. Line 300: self._addNetworkWithExc((netinfoIns, 'test', vlan, bonding, ['eth7'], Line 301: ipaddr, netmask, gw, bondingOptions), Line 302: configNetwork.ne.ERR_BAD_PARAMS) Line 303: -- To view, visit http://gerrit.ovirt.org/7241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I732c8c9f1983261391835e1e3687cf120e9def34 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
