Nir Soffer has posted comments on this change. Change subject: supervdsm: remove unneeded version check ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/44844/1//COMMIT_MSG Commit Message: Line 8: Line 9: We now require higher version of systemd than 181, therefore checking Line 10: that version > 181 is not required anymore. This also removes the need Line 11: for branch in __udevReloadRules because the argument will always be Line 12: --version. > s/--version/--reload/ Also, this text is not very clear if you don't look into the code. This should explain that the required udevadm version has a --reload option, so we don't need the version any more, or use different arguments based on the version check. Line 13: Line 14: Change-Id: I47aa14c1f084b9d8456dc39b6da171188387b233 -- To view, visit https://gerrit.ovirt.org/44844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47aa14c1f084b9d8456dc39b6da171188387b233 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
