Dan Kenigsberg has posted comments on this change. Change subject: Introduce a new verb setBalloonTarget ......................................................................
Patch Set 8: (2 inline comments) .................................................... File vdsm_api/vdsmapi-schema.json Line 5015: # @VM.setBalloonTarget: Line 5016: # Line 5017: # Dynamically change the target amount of physical memory allocated to a guest. Line 5018: # Line 5019: # @target: The target of guest's physical memory size in kibibytes Are you sure, Adam? I see no unit translation here, and libvirt accpets KiB http://libvirt.org/html/libvirt-libvirt.html#virDomainSetMemory Line 5020: # Line 5021: # Since: 4.10.0 Line 5022: ## Line 5023: {'command': {'class': 'VM', 'name': 'setBalloonTarget'}, .................................................... File vdsm/libvirtvm.py Line 2159: self.log.error("Set new balloon target failed", exc_info=True) Line 2160: if msg == None: Line 2161: error = errCode[key] Line 2162: else: Line 2163: error = {'status' : {'code': errCode[key] \ needless trailing backslash Line 2164: ['status']['code'], 'message': msg}} Line 2165: return error Line 2166: Line 2167: if self._dom == None: -- To view, visit http://gerrit.ovirt.org/3669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36b1211dbce28bb5bb5926f2db7e2e42a698efc9 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
