Nir Soffer has posted comments on this change. Change subject: multiapth: Tell the user about backups ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/44867/3/lib/vdsm/tool/configurators/multipath.py File lib/vdsm/tool/configurators/multipath.py: Line 125: Line 126: if os.path.exists(_CONF_FILE): Line 127: backup = _CONF_FILE + '.' + time.strftime("%Y%m%d%H%M") Line 128: shutil.copyfile(_CONF_FILE, backup) Line 129: sys.stdout.write("Backup multipath.conf to %r\n" % backup) > add: Maybe "Backup current multipath.conf to ..."? Line 130: utils.persist(backup) Line 131: Line 132: with tempfile.NamedTemporaryFile() as f: Line 133: f.write(_CONF_DATA) -- To view, visit https://gerrit.ovirt.org/44867 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e16c34c2a7410d78b7351fd0a6b7fc9c527d668 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
