Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: periodic: NumaInfoMonitor doesn't need jobs ......................................................................
vm: periodic: NumaInfoMonitor doesn't need jobs The Vm.isDomainReadyForCommands() is a borderline hack that relies on virDomainGetControlInfo, which, in turn, tells the caller about the hypervisor monitor traffic. In the case of NumaInfoMonitor, this protection has zero positive value (only adds libvirt traffic) because the libvirt API used internally by NumaInfoMonitor do not need to access the QEMU monitor, but only data from /proc. Hence, remove the call to reduce libvirt traffic and to reduce false negative reported: periodic/3::WARNING::2015-08-12 15:02:57,855::periodic::253::virt.periodic.VmDispatcher::(__call__) could not run <class 'virt.periodic.NumaInfoMonitor'> on [u'5b44bc17-99ba-4c9d-a3c5-fcd913c87361'] X-Backport-To: 3.6 Change-Id: I50c68b8b00ea0f9c137ce8149f3a806c62be7f6d Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: https://gerrit.ovirt.org/44763 Reviewed-by: Dan Kenigsberg <[email protected]> Continuous-Integration: Dan Kenigsberg <[email protected]> --- M vdsm/virt/periodic.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dan Kenigsberg: Looks good to me, approved; Passed CI tests Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/44763 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50c68b8b00ea0f9c137ce8149f3a806c62be7f6d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
