Dima Kuznetsov has posted comments on this change. Change subject: oop: close ioprocesses on vdsmd stop ......................................................................
Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/45038/1/init/systemd/vdsmd.service.in File init/systemd/vdsmd.service.in: Line 20: User=@VDSMUSER@ Line 21: Group=@VDSMGROUP@ Line 22: PermissionsStartOnly=true Line 23: TimeoutStopSec=@SERVICE_STOP_TIMEOUT@ Line 24: KillMode=process I think its worth adding a FIXME here noting we should switch to 'mixed' mode if/when el7 systemd supports it. Line 25: Line 26: [Install] -- To view, visit https://gerrit.ovirt.org/45038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a7554609e5b43d6fce3dd3c4c1817cc98372b6c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
