Francesco Romani has posted comments on this change. Change subject: vm: fix misleading XML log ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/44843/8/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1890: silliness > in "silliness", do you mean the odd semantics about "before_vm_start" havin Good point, will fix. The "silliness" is because the dehibernate flow - feds the hook with wrong data - doesn't make use of the of the output of the hook -- To view, visit https://gerrit.ovirt.org/44843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50f5b8a51830c8ce2a098e4ac11dd1bd6a89aac3 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
