Dan Kenigsberg has submitted this change and it was merged. Change subject: multiapth: Reorganize constants and improve documentation ......................................................................
multiapth: Reorganize constants and improve documentation It is nicer to work with code when related items are grouped together and when groups have documentation. Now the module start with a description of the VDSM REVISION tag, which must be in the first line of the file, followed by the current and old tag values. Then we discuss the VDSM PRIVATE tag, which may be in the second line, followed by the current and old tag values. Previously you had to read the code to understand this logic. Change-Id: Id853b50ede32d9f0b05ef610ec5008b1d4ead2da Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/44863 Continuous-Integration: Jenkins CI Reviewed-by: Yeela Kaplan <[email protected]> Reviewed-by: Allon Mureinik <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/tool/configurators/multipath.py 1 file changed, 23 insertions(+), 21 deletions(-) Approvals: Nir Soffer: Verified Yeela Kaplan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/44863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id853b50ede32d9f0b05ef610ec5008b1d4ead2da Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
