Yeela Kaplan has uploaded a new change for review. Change subject: init: add a lock when starting / stopping svdsm ......................................................................
init: add a lock when starting / stopping svdsm This will prevent a very uncomrfotable situation where 2 supervdsm processes co-exist at the same time. Change-Id: I10bb3f7d39b7dc6a61bce99fab718b51496a37b0 Signed-off-by: Yeela Kaplan <[email protected]> --- M init/sysvinit/supervdsmd.init.in 1 file changed, 16 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/02/45202/1 diff --git a/init/sysvinit/supervdsmd.init.in b/init/sysvinit/supervdsmd.init.in index f3369c2..6874476 100755 --- a/init/sysvinit/supervdsmd.init.in +++ b/init/sysvinit/supervdsmd.init.in @@ -70,13 +70,27 @@ return "$RETVAL" } +lock_op() { + { + if ! flock -n 9; then + log_failure_msg $"cannot ${1} ${prog}, operation is locked" + false + elif ( "${1}" 9<&- ); then + log_success_msg $"${prog} ${1}" + else + log_failure_msg $"${prog} ${1}" + false + fi + } 9<$0 +} + case "$1" in start) - start + lock_op start RETVAL=$? ;; stop) - stop + lock_op stop RETVAL=$? ;; status) -- To view, visit https://gerrit.ovirt.org/45202 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I10bb3f7d39b7dc6a61bce99fab718b51496a37b0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yeela Kaplan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
