Ondřej Svoboda has uploaded a new change for review. Change subject: iproute2, pyroute2: bonding options are still a string, so split() ......................................................................
iproute2, pyroute2: bonding options are still a string, so split() Broken by commit a3bb8de5. Change-Id: I6b2d0563eae24c0355c2ba6ed8db919ae545b595 Signed-off-by: Ondřej Svoboda <[email protected]> --- M vdsm/network/configurators/iproute2.py M vdsm/network/configurators/pyroute_two.py 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/45234/1 diff --git a/vdsm/network/configurators/iproute2.py b/vdsm/network/configurators/iproute2.py index 4f58fba..b1fb51f 100644 --- a/vdsm/network/configurators/iproute2.py +++ b/vdsm/network/configurators/iproute2.py @@ -345,7 +345,7 @@ logging.debug('Add bond options %s', bond.options) # 'custom' is not a real bond option, it just piggybacks custom values options = remove_custom_bond_option(bond.options) - for option in options: + for option in options.split(): key, value = option.split('=') with open(netinfo.BONDING_OPT % (bond.name, key), 'w') as f: f.write(value) diff --git a/vdsm/network/configurators/pyroute_two.py b/vdsm/network/configurators/pyroute_two.py index 1293310..652e1dc 100644 --- a/vdsm/network/configurators/pyroute_two.py +++ b/vdsm/network/configurators/pyroute_two.py @@ -156,7 +156,7 @@ logging.debug('Add bond options %s', bond.options) # 'custom' is not a real bond option, it just piggybacks custom values options = remove_custom_bond_option(bond.options) - for option in options: + for option in options.split(): key, value = option.split('=') with open(netinfo.BONDING_OPT % (bond.name, key), 'w') as f: f.write(value) -- To view, visit https://gerrit.ovirt.org/45234 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6b2d0563eae24c0355c2ba6ed8db919ae545b595 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
