Timothy Asir has posted comments on this change. Change subject: gluster: fix xfs filesystem is created with wrong inode size ......................................................................
Patch Set 4: (1 comment) No change in the test case https://gerrit.ovirt.org/#/c/43847/4/vdsm/gluster/storagedev.py File vdsm/gluster/storagedev.py: Line 325: "-d", "sw=%s,su=%sk" % (count, raidParams.get('stripeSize')), Line 326: "-n", "size=8192"] Line 327: else: Line 328: format._defaultFormatOptions = ["-f", "-i", "size=512", Line 329: "-n", "size=8192"] > How about rewriting this if block as Done Line 330: blivetEnv.formatDevice(thinlv, format) Line 331: blivetEnv.doIt() Line 332: Line 333: try: -- To view, visit https://gerrit.ovirt.org/43847 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3f350d2f79172705a93a9d69fe1b7b78867861e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan Narayana Murthy <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
