Dan Kenigsberg has posted comments on this change. Change subject: caps: more precise emulated machines selection ......................................................................
Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/45257/4/tests/caps_libvirt_multiqemu.out File tests/caps_libvirt_multiqemu.out: Line 228: <domain type='kvm'> please use this to identify the desired domain type - I think it's safer than peeking into <emulator>. but make sure that faqemu keeps working on hosts with no vmx. https://gerrit.ovirt.org/#/c/45257/4/vdsm/caps.py File vdsm/caps.py: Line 420: machines.keys() six.moves.keys(machines) Line 417: Line 418: def _pickEmulatedMachines(machines): Line 419: for desired in ('qemu-kvm', 'qemu-system-x86_64',): # FIXME: ppc64le? Line 420: for candidate in machines.keys(): Line 421: if desired in candidate: searching for a string in some place in a string is not very safe. please use endswith Line 422: return machines[candidate] Line 423: Line 424: return [] Line 425: -- To view, visit https://gerrit.ovirt.org/45257 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4deebbc90bf1cec53fc40bc6a35c6ada933296c3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
