Ondřej Svoboda has posted comments on this change.

Change subject: Revert "tests: functional - convert to run over jsonrpc"
......................................................................


Patch Set 1: -Verified

There are multiple issues.

A "cure" to one -- the server side not properly naming parameters transferred 
as a list (which is schema violation, though) is 
https://gerrit.ovirt.org/#/c/45274/

A better solution is to let jsonrpcvdscli's _Server._callMethod accept a 
dictionary or kwargs instead of positional args (that also inevitably lose 
their name in JSON representation).

-- 
To view, visit https://gerrit.ovirt.org/45266
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib45fbaa84e25e3c72aa09bfa78c16dd700e6e957
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com>
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to