Dima Kuznetsov has posted comments on this change. Change subject: Revert "supervdsm: Decorator for supervdsm proxied calls." ......................................................................
Patch Set 1: I think the ease of use is not a vice. It faces only the developer of the function, and not the user, and allows you keep all the code related to some topic in the same place (vs another method in supervsdmServer). IMO it's irrelevant for whoever uses a specific function, to know whether it should be called through supervdsm proxy or otherwise. One such example is reading hardware info, you care about getting the system data, implementation details (such that dmidecode requires privileges) should be part of the concerns. And I'd trust whoever writes the module to tag only the relevant parts for supervdsm invocation. -- To view, visit https://gerrit.ovirt.org/45316 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f83b4a8820f3fef437641329ba514742434dab4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
