Nir Soffer has posted comments on this change. Change subject: jsonrpc: executor based thread factory ......................................................................
Patch Set 7: Code-Review-1 (1 comment) -1 for visibility https://gerrit.ovirt.org/#/c/43759/7/vdsm/rpc/bindingjsonrpc.py File vdsm/rpc/bindingjsonrpc.py: Line 37: workers_count=_THREADS, Line 38: max_tasks=_TASKS, Line 39: scheduler=scheduler) Line 40: Line 41: self._server = JsonRpcServer(bridge, timeout, self._executor.dispatch) dispatch may raise executor.TooManyTasks - is JsonRpcServer handling this exception correctly? Line 42: self._reactor = StompReactor(subs) Line 43: self.startReactor() Line 44: Line 45: def add_socket(self, reactor, client_socket): -- To view, visit https://gerrit.ovirt.org/43759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56b307633a8bf7e4aad8f87cc97a4129c9ed0970 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
