Hello Nir Soffer, Bala.FA,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/45369

to review the following change.

Change subject: gluster:cleanup: Remove unnecessary wrapper
......................................................................

gluster:cleanup: Remove unnecessary wrapper

Existing wrapper is redundant as it does not provide any logic to the method.
Hence, the decision to remove it.

Change-Id: I9ff1b4f785f453a6fbf1660949db779712d88758
Signed-off-by: Ala Hino <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/45097
Reviewed-by: Nir Soffer <[email protected]>
Reviewed-by: Bala.FA <[email protected]>
Continuous-Integration: Dan Kenigsberg <[email protected]>
---
M vdsm/gluster/__init__.py
1 file changed, 2 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/45369/1

diff --git a/vdsm/gluster/__init__.py b/vdsm/gluster/__init__.py
index 0566ceb..dd363d6 100644
--- a/vdsm/gluster/__init__.py
+++ b/vdsm/gluster/__init__.py
@@ -20,19 +20,14 @@
 
 import os
 import tempfile
-from functools import wraps
 
 MODULE_LIST = ('cli', 'hooks', 'services', 'tasks',
                'gfapi', 'storagedev', 'api')
 
 
 def makePublic(func):
-    @wraps(func)
-    def wrapper(*args, **kwargs):
-        return func(*args, **kwargs)
-
-    wrapper.superVdsm = True
-    return wrapper
+    func.superVdsm = True
+    return func
 
 
 def listPublicFunctions():


-- 
To view, visit https://gerrit.ovirt.org/45369
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ff1b4f785f453a6fbf1660949db779712d88758
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to