Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: add and use vm.acpiReboot() method ......................................................................
virt: add and use vm.acpiReboot() method The VM powerdown flow, implemented into the vmpowerdown.py module, needs to call libvirt APIs to trigger the actual shutdown or reboot operations. To do so, it directly accesses the Vm._dom private attribute, which is impolite and evil. This patch adds acpiReboot public method, with built-in protection against asynchronous QEMU death. This of course adds more code to the already fat vm.py, but improves isolation among modules, which is a greater good. Change-Id: I5d6dd3a81cd4ad981a839849a4a2914e35a53fa6 Related-To: https://bugzilla.redhat.com/1154389 Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: https://gerrit.ovirt.org/44923 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg <[email protected]> --- M tests/vmTests.py M tests/vmfakelib.py M vdsm/virt/vm.py M vdsm/virt/vmpowerdown.py 4 files changed, 27 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/44923 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d6dd3a81cd4ad981a839849a4a2914e35a53fa6 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
