Nir Soffer has posted comments on this change. Change subject: Update v2v to use new jobs infrastructure ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/45382/1/vdsm/v2v.py File vdsm/v2v.py: Line 101 Line 102 Line 103 Line 104 Line 105 > Agreed, this is a general v2v bug and not part of this refactoring. Sure Line 116 Line 117 Line 118 Line 119 Line 120 > V2VErrors are not descendant from jobs.ClientError so they needn't conform I agree, lets keep this change minimal. Line 124 Line 125 Line 126 Line 127 Line 128 > Agreed, but not related to this patch. If this can be raised as an API lev Agree -- To view, visit https://gerrit.ovirt.org/45382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9118e0fe4aaeceab2109afa393dd45fbd97e070f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
